HEPCloud / decisionengine_modules

Apache License 2.0
2 stars 19 forks source link

New Figure of Merit Metric #495

Closed skylerfoster67 closed 5 months ago

skylerfoster67 commented 5 months ago

Added a new metric that catches figure of merit calculations in "figure_of_merit.py" located in decisionengine_modules/src/decisionengine_modules/util and instrumented "grid_figure_of_merit.py" located in decisionengine_modules/src/decisionengine_modules/glideinwms/transforms

pep8speaks commented 5 months ago

Hello @skylerfoster67! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 40:1: W293 blank line contains whitespace Line 42:25: E126 continuation line over-indented for hanging indent Line 51:17: F821 undefined name 'FIGURE_OF_MERIT_CALCULATION' Line 52:25: E126 continuation line over-indented for hanging indent

Line 14:9: E126 continuation line over-indented for hanging indent Line 27:17: E126 continuation line over-indented for hanging indent Line 27:41: W291 trailing whitespace Line 28:33: W291 trailing whitespace Line 29:33: W291 trailing whitespace Line 30:27: W291 trailing whitespace