HEPCloud / decisionengine_modules

Apache License 2.0
2 stars 19 forks source link

New Figure of Merit Metric #496

Closed skylerfoster67 closed 4 months ago

skylerfoster67 commented 5 months ago

Added a new metric that catches figure of merit calculations in "figure_of_merit.py" located in decisionengine_modules/src/decisionengine_modules/util and instrumented "grid_figure_of_merit.py" located in decisionengine_modules/src/decisionengine_modules/glideinwms/transforms

pep8speaks commented 5 months ago

Hello @skylerfoster67! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-04-29 15:50:29 UTC
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.59%. Comparing base (4f590a6) to head (0401960). Report is 2 commits behind head on master.

:exclamation: Current head 0401960 differs from pull request most recent head 950637e. Consider uploading reports for the commit 950637e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #496 +/- ## ========================================== - Coverage 47.84% 47.59% -0.25% ========================================== Files 54 54 Lines 2951 2937 -14 Branches 510 506 -4 ========================================== - Hits 1412 1398 -14 Misses 1439 1439 Partials 100 100 ``` | [Flag](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/496/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | Coverage Δ | | |---|---|---| | [python-3.8](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/496/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | `47.59% <100.00%> (-0.25%)` | :arrow_down: | | [python-3.9](https://app.codecov.io/gh/HEPCloud/decisionengine_modules/pull/496/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud) | `47.59% <100.00%> (-0.25%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HEPCloud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mambelli commented 4 months ago

Then address the PEP8 comments if they still apply. If you have the pre-commit checks pep8speaks stuff should be already addressed by the checks