HEPCloud / decisionengine_modules

Apache License 2.0
2 stars 19 forks source link

add new method of determining token expiration instaed of relying on jwt.decode error code #502

Open StevenCTimm opened 3 months ago

StevenCTimm commented 3 months ago

Hyunwoo changed the code such that it actually calculates whether the token is expired rather than just relying on jwt.decode to throw an error. Also have to adjust for the fact that every systemd process in AL9 has its own /tmp area created for it on the spot so there will always have to be a new token rawfile generated on the first startup.

pep8speaks commented 3 months ago

Hello @StevenCTimm! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-07-31 15:53:00 UTC
StevenCTimm commented 3 months ago

I have now made a version without all the print statements but haven't been able to get it pushed from either of my current places I have this branch downloaded. [timm@snowball sources]$ git status On branch timm_nerscsfapi Your branch and 'origin/timm_nerscsfapi' have diverged, and have 2 and 2 different commits each, respectively. (use "git pull" to merge the remote branch into yours)

nothing to commit, working tree clean

StevenCTimm commented 1 month ago

OK I was able to force-push the branch as I had it.. please review the latest changes I made and be sure they are OK.