HEPData / hepdata

Repository for main HEPData web application
https://hepdata.net
GNU General Public License v2.0
40 stars 11 forks source link

records: fix issues loading large files #756

Closed GraemeWatt closed 4 months ago

GraemeWatt commented 5 months ago

I noticed a couple of issues with https://www.hepdata.net/record/ins2752118 where the second table is larger than the automatic loading threshold and its description contains LaTeX encoding. There seem to be a couple of bugs that were missed in the original testing of #733.

  1. Normally, table descriptions containing LaTeX encoding are rendered using MathJax, but this does not happen before clicking "Load Table":

    Screenshot 2024-02-02 at 10 48 27
  2. If other (smaller) tables are loaded before the second (larger) table, there is overlap between the display of the number of values:

    Screenshot 2024-02-02 at 10 46 53

Could you please fix these two bugs, @ItIsJordan?

GraemeWatt commented 5 months ago

I have found further related issues this week as we just discussed @ItIsJordan:

GraemeWatt commented 5 months ago

@ItIsJordan : another related bug just reported by a user. The JSON links for individual tables are currently broken because they link to /data/<int:recid>/<int:data_recid>/<int:version> without the extra <int:load_all> argument. This route should be reinstated with a default value of load_all = 1 if not specified explicitly. See converter/views.py for examples of functions with multiple routes.