search

HEPData / hepdata_lib

Library for getting your data into HEPData
https://hepdata-lib.readthedocs.io
MIT License
16 stars 39 forks source link

A possibility to make bins with weighted averages added. #146

Open szymonharabasz opened 4 years ago

szymonharabasz commented 4 years ago

This allows to make entires of the type: { value: 1.5, low: 1.0, high:2.0 }. Such a feature is necessary to submit data from figures like Fig. 6 in: https://doi.org/10.1103/PhysRevC.80.044905

clelange commented 4 years ago

Hi @szymonharabasz - thanks a lot for this contribution! There's something with the tests, they all fail, but it doesn't seem to have anything to do with the code you added. I'll try to have a look at this next week.

Independently, do you think you could write some tests so that we can be sure this feature won't break in the future? Let me know if you need any help with that.

AndreasAlbert commented 4 years ago

Hi, indeed the linuxpy3 jobs fail mysteriously, but the linuxpy2 and macos jobs fail due to real pylint complaints:

Using config file /home/runner/work/hepdata_lib/hepdata_lib/pylintrc
************* Module hepdata_lib.__init__
C: 56, 0: Line too long (114/100) (line-too-long)
C: 94, 0: Line too long (110/100) (line-too-long)
C:189, 0: Wrong continued indentation (add 2 spaces).
                                                          self.digits)
                                                          ^ | (bad-continuation)

-----------------------------------
Your code has been rated at 9.97/10

@szymonharabasz these are prettey straightforward white space / line length isues. If you could fix these, we might get a clearer picture of what other tests are failing and why.

szymonharabasz commented 4 years ago

Hi, sure, I can fix the pylint issues. Test for the new feature I plan to write within this week.

czw., 1 paź 2020 o 13:59 Andreas notifications@github.com napisał(a):

Hi, indeed the linuxpy3 jobs fail mysteriously, but the linuxpy2 and macos jobs fail due to real pylint complaints:

Using config file /home/runner/work/hepdata_lib/hepdata_lib/pylintrc ***** Module hepdata_lib.init C: 56, 0: Line too long (114/100) (line-too-long) C: 94, 0: Line too long (110/100) (line-too-long) C:189, 0: Wrong continued indentation (add 2 spaces). self.digits) ^ | (bad-continuation)

Your code has been rated at 9.97/10

@szymonharabasz https://github.com/szymonharabasz these are prettey straightforward white space / line length isues. If you could fix these, we might get a clearer picture of what other tests are failing and why.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HEPData/hepdata_lib/pull/146#issuecomment-702085423, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEATVUYOOYZ42LJ33AGBY7TSIRVKVANCNFSM4R57M4FQ .