search

HEPData / hepdata_lib

Library for getting your data into HEPData
https://hepdata-lib.readthedocs.io
MIT License
15 stars 39 forks source link

WIP: revive macOS CI #171

Closed AndreasAlbert closed 1 year ago

clelange commented 3 years ago

Currently, we get Python 3.9.5 with homebrew/ROOT as default. Any particular reason why you're explicitly choosing Python 3.8 here?

AndreasAlbert commented 3 years ago

No, tbh, I was just playing around trying to get it to work. (I did not know the python version from homebrew/ROOT)

AndreasAlbert commented 3 years ago

I'm confused actually that this now says that tests pass...When I last touched the code, I thought the tests were still failing? oO

clelange commented 3 years ago

We can stick to Python 3.8 or we go with the Homebrew default that we get with root (i.e not even install python explicitly with brew, but only brew install root). The latter might be easier. I'm actually a bit surprised this didn't cause issues.

matthewfeickert commented 1 year ago

@clelange I think this can get closed given the addition of

https://github.com/HEPData/hepdata_lib/blob/21349a6f39726e7c7a1ddaa683a87f32e70ab79b/.github/workflows/tests.yml#L38-L41

in PR #220.

clelange commented 1 year ago

Superseded by #220