HEPData / hepdata_lib

Library for getting your data into HEPData
https://hepdata-lib.readthedocs.io
MIT License
15 stars 39 forks source link

package 'six' not required on installation #175

Closed butsuri43 closed 3 years ago

butsuri43 commented 3 years ago

It seems that six is not required on installation (https://github.com/HEPData/hepdata_lib/blob/master/setup.py#L11) but it is actually required in helpers.py (https://github.com/HEPData/hepdata_lib/blob/master/hepdata_lib/helpers.py#L11) and caused my fresh installation to run with error.

clelange commented 3 years ago

Thanks for pointing this out. One of the dependencies that we have listed had six as an dependency, but it is possible that that package moved entirely to Python 3 and removed this dependency. Which Python version are you using and on which operating system?

fcatalan92 commented 3 years ago

Thanks for pointing this out. One of the dependencies that we have listed had six as an dependency, but it is possible that that package moved entirely to Python 3 and removed this dependency. Which Python version are you using and on which operating system?

Hi, I can confirm this problem for v0.8.0 with Python 3.8.10 on Ubuntu 20.04.

clelange commented 3 years ago

@butsuri43 @fcatalan92 - can you try with v0.8.1 that we just released and if the problem isn't fixed, please reopen this issue?

fcatalan92 commented 3 years ago

Hi @clelange, v0.8.1 works for me!

butsuri43 commented 3 years ago

Hey,

Sorry for being silent. Indeed v0.8.1 works for me as well on Python 3.9.2. Many thanks for the fix!