search

HEPData / hepdata_lib

Library for getting your data into HEPData
https://hepdata-lib.readthedocs.io
MIT License
15 stars 39 forks source link

Move pylint to test dependencies and split python2 and 3 version requ… #182

Closed clelange closed 2 years ago

clelange commented 2 years ago

…irements

This makes hepdata_lib work again with Python2.7, e.g. on LXPLUS.

I'll follow up with a few smaller PRs to see if we can make tests work again for 2.7 as well.

Fixes #181

clelange commented 2 years ago

Oh dear, they joys of pylint... the things you do for code quality 😉

AndreasAlbert commented 2 years ago

Thanks! Does this work for you on lxplus? When trying to install on python 2.7 on lxplus, I get distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pytest-cov')

clelange commented 2 years ago

I've tried it with the latest CMSSW_10_6_X release: CMSSW_10_6_29 and managed to pip install the library. The tests don't work yet. Did you use plain system python on lxplus7?

clelange commented 2 years ago

I tried simplifying further, but that doesn't seem to work (see https://github.com/HEPData/hepdata_lib/pull/182/commits/6647715b3b8c1fe0795e7dbb13c8cebbeb384cb5). The system python on lxplus7 is 2.7.5, but there's also 3.6.8 available, so one really shouldn't use python2 here.