Closed matthewfeickert closed 1 year ago
Merging #220 (7fd168a) into master (3732906) will increase coverage by
0.20%
. The diff coverage isn/a
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 87.80% 88.01% +0.20%
==========================================
Files 4 4
Lines 968 968
Branches 189 202 +13
==========================================
+ Hits 850 852 +2
+ Misses 86 85 -1
+ Partials 32 31 -1
Flag | Coverage Δ | |
---|---|---|
unittests-3.10 | 88.01% <ø> (?) |
|
unittests-3.6 | 87.66% <ø> (?) |
|
unittests-3.7 | 87.66% <ø> (?) |
|
unittests-3.8 | 87.80% <ø> (ø) |
|
unittests-3.9 | 87.80% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
hepdata_lib/c_file_reader.py | 92.94% <0.00%> (+0.64%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@clelange once PR #218 is merged I can rebase this and then it will be ready to go.
@clelange thanks for the fast review and merge of PR #218! This is now ready for review. :+1:
Thanks again! I'll merge this and will then make a new release so that python 2 can then be deprecated.
If you want to make a release before removing Python 2 support then let me make a PR that adds a python_requires
(PR #222) before you make the release so that this release gets that. I would also recommend making a minor release after PR #221 to signify that a Python version has been dropped.
Requires #218 to go in first.
:books: Documentation preview :books:: https://hepdata-lib--220.org.readthedocs.build/en/220/