matthewfeickert commented 1 year ago

Resolves #219
Should follow PR #220.
Requires PR #222 to go in first.

Add requires-python metadata that requires Python 3.6+ for installation.
Drop support for Python 2 by removing the universal information for wheels and qualifiers of Python version for pylint.
- Remove setup.cfg as it was only holding universal wheel information and is currently not being used to hold any other configuration information
Add Python 3.8, 3.9, 3.10 PyPI troves metadata.

:books: Documentation preview :books:: https://hepdata-lib--221.org.readthedocs.build/en/221/

codecov-commenter commented 1 year ago

Codecov Report

Merging #221 (aa18b06) into master (b296d5b) will increase coverage by 0.35%. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
+ Coverage   88.01%   88.36%   +0.35%     
==========================================
  Files           4        4              
  Lines         968      963       -5     
  Branches      202      200       -2     
==========================================
- Hits          852      851       -1     
+ Misses         85       82       -3     
+ Partials       31       30       -1

Flag	Coverage Δ
unittests-3.10	`88.36% <ø> (+0.35%)`	:arrow_up:
unittests-3.6	`88.02% <ø> (+0.35%)`	:arrow_up:
unittests-3.7	`88.02% <ø> (+0.35%)`	:arrow_up:
unittests-3.8	`88.16% <ø> (+0.35%)`	:arrow_up:
unittests-3.9	`88.16% <ø> (+0.35%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
hepdata_lib/c_file_reader.py	`94.13% <ø> (+1.18%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

clelange commented 1 year ago

https://pypi.org/project/hepdata-lib/0.11.1/ is up, so we can move ahead here. The metadata "requires" looks a bit odd on PyPI, but I guess this is OK?

Requires: Python >=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, !=3.5.*

matthewfeickert commented 1 year ago

To make things more atomic, I moved all the code cleaning and updating to PR #223, so this one just updates the build dependencies and metadata to Python 3.6+.

matthewfeickert commented 1 year ago

https://pypi.org/project/hepdata-lib/0.11.1/ is up, so we can move ahead here. The metadata "requires" looks a bit odd on PyPI, but I guess this is OK?
Requires: Python >=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, !=3.5.* 

Yes, this is fine for Python 3.6+

$ docker run --rm -ti python:3.6 /bin/bash
root@26b90d626fa6:/# python -m venv venv && . venv/bin/activate
(venv) root@26b90d626fa6:/# python -m pip --quiet install --upgrade pip setuptools wheel
(venv) root@26b90d626fa6:/# python -m pip --quiet install hepdata-lib
(venv) root@26b90d626fa6:/# python -m pip show hepdata-lib
Name: hepdata-lib
Version: 0.11.1
Summary: Library for getting your data into HEPData
Home-page: https://github.com/HEPData/hepdata_lib
Author: Andreas Albert, Clemens Lange
Author-email: hepdata-lib@cern.ch
License: UNKNOWN
Location: /venv/lib/python3.6/site-packages
Requires: future, hepdata-validator, numpy, PyYAML, six
Required-by: 
(venv) root@26b90d626fa6:/#

though c.f. Issue #224 for my recommendations on what to do once https://github.com/HEPData/hepdata_lib/pull/222#issuecomment-1441355145 is finished and there is a Python 3.6+ only release v0.12.0 out.

matthewfeickert commented 1 year ago

@clelange this is ready for review now. Let me know if you have any questions.

HEPData / hepdata_lib

build: Require Python 3.6+ for install #221

Codecov Report