HEPData / hepdata_lib

Library for getting your data into HEPData
https://hepdata-lib.readthedocs.io
MIT License
16 stars 39 forks source link

Related records #232

Closed ItIsJordan closed 1 year ago

ItIsJordan commented 1 year ago

This pull request provides support for the new bidirectional linking features of HEPData (docs). Adds support for the new related data fields.


:books: Documentation preview :books:: https://hepdata-lib--232.org.readthedocs.build/en/232/

codecov-commenter commented 1 year ago

Codecov Report

Merging #232 (2ba4dc8) into master (407b14b) will increase coverage by 0.24%. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   88.28%   88.52%   +0.24%     
==========================================
  Files           4        4              
  Lines         956      976      +20     
  Branches      200      202       +2     
==========================================
+ Hits          844      864      +20     
  Misses         82       82              
  Partials       30       30              
Flag Coverage Δ
unittests-3.10 88.52% <100.00%> (+0.24%) :arrow_up:
unittests-3.6 88.18% <100.00%> (+0.25%) :arrow_up:
unittests-3.7 88.18% <100.00%> (+0.25%) :arrow_up:
unittests-3.8 88.31% <100.00%> (+0.24%) :arrow_up:
unittests-3.9 88.31% <100.00%> (+0.24%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
hepdata_lib/__init__.py 90.51% <100.00%> (+0.61%) :arrow_up:
clelange commented 1 year ago

Thanks for this! Is there a real need to deprecate support for python 3.6? I know it's end-of-life, but there are still lots of systems around that have this as default version.

GraemeWatt commented 1 year ago

Thanks for this! Is there a real need to deprecate support for python 3.6? I know it's end-of-life, but there are still lots of systems around that have this as default version.

I was planning to ask you about this, @clelange. The issue I had was that the CI (using GitHub Actions) for the hepdata-validator started failing for Python 3.6 using the ubuntu-latest image (see actions/setup-python/issues/544). I thought it was simplest just to drop Python 3.6 support given that security support ended on 23 Dec 2021 (https://endoflife.date/python). If you really need hepdata_lib to be compatible with Python 3.6, I can look into reinstating support for the hepdata-validator (for example, by testing with an older Ubuntu image) and release a new version of the hepdata-validator, but I'm reluctant to do this unless it's really needed. At some point, people need to move to newer Python versions. Let me know what you think.

GraemeWatt commented 1 year ago

Thanks for this! Is there a real need to deprecate support for python 3.6? I know it's end-of-life, but there are still lots of systems around that have this as default version.

On reflection, I agree that we don't need to drop Python 3.6 support unnecessarily. I've just merged HEPData/hepdata-validator#54 that uses the older ubuntu-20.04 image to run Python 3.6 tests (and I've added tests for Python 3.10 and 3.11). I've released a new version hepdata-validator 0.3.5 that supports Python 3.6.

@ItIsJordan, can you please upgrade the hepdata-validator version and revert 009478b4c048a58ab447b90982a0d16c9ce03a62?

Update: it looks like the hepdata_lib CI doesn't have the same problem because it uses Micromamba to install Python, so that's why ubuntu-latest works with Python 3.6.

ItIsJordan commented 1 year ago

I have made those changes now.

clelange commented 1 year ago

I made one small change, now just waiting for the tests to pass, then I will merge and create a new release this afternoon.