Closed GraemeWatt closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.37%. Comparing base (
ba9f2e2
) to head (e0c9d26
). Report is 8 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
https://github.com/HEPData/hepdata_lib/blob/ba9f2e28e33e59bb2bf5b429cab97d31cd556538/.github/workflows/tests.yml#L144-L148
I noticed in PR #265 that the CI is successful for commit 81adb429876820762c6b8608b9f36cc69d1040e9 (workflow run) despite the command
python -m pylint hepdata_lib/*.py
giving a exit code 8 with a message:Thus it looks like only the second command
python -m pylint tests/*.py
givingYour code has been rated at 10.00/10
(exit code 0) determines whether the "Run pylint" step passes or fails. The subsequent commit 51f13c107270af2c7c3ba6aec561f9701683ce06 (workflow run) gives issues for both thehepdata_lib
andtests
directories and the "Run pylint" step fails. This PR therefore separates the single "Run pylint" step into separate steps for thehepdata_lib
andtests
directories so that a code rating less than 10.00/10 (corresponding to a non-zero exit code forpylint
) for either directory will result in the CI failing.📚 Documentation preview 📚: https://hepdata-lib--267.org.readthedocs.build/en/267/