[Bug]: Ensure user is only created/modified, if update works as well and data is correct

HEPTACOM / HeptacomShopwarePlatformAdminOpenAuth

Shopware plugin to allow open auth logins in the administration

https://www.heptacom.de/

Apache License 2.0

30 stars 10 forks source link

[Bug]: Ensure user is only created/modified, if update works as well and data is correct #13

Open AndreasA opened 1 year ago

AndreasA commented 1 year ago

Plugin Version

4.2.1

PHP Version

8.1

Shopware Version

6.4.18.1

Installation method

Composer

Identity provider

Google Cloud

What happened?

It would probably be a good idea to put the whole user creation / update part in a database transaction with commit/rollback, so only upon success the user created / modified if everything works correctly.

Relevant log output

No response

JoshuaBehrens commented 1 year ago

That is a good input. For this we need to validate, that we keep everything in that transaction. It is unlikely that we provide an update for the Shopware 6.4 plugin version as we are in a refactoring process for Shopware 6.5. But we keep that in mind in our refactoring, that we make this safer in its process.