search

HEPTACOM / HeptacomShopwarePlatformAdminOpenAuth

Shopware plugin to allow open auth logins in the administration
https://www.heptacom.de/
Apache License 2.0
30 stars 10 forks source link

Changes to run with Shopware 6.6 #24

Closed stefpe closed 4 months ago

stefpe commented 4 months ago

Updated to run with Shopware 6.6. What I was not able to fix is the save button in the admin area. It looks like the model for the client doesn't get any update.

CLAassistant commented 4 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

d435345 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

JoshuaBehrens commented 4 months ago

Hi @stefpe thank you for reaching us with your upgrade path. We will compare it against our release candidate if we were missing something :)

silviokennecke commented 4 months ago

Hi @stefpe, I just compared your PR to our RC and will therefore close your PR. The actual release will be done later today.

Regarding your issue with the save button / model: In vue 3 the syntax for binding slightly changed from v-model to v-model:value. This allows you to have two-way bindings for multiple attributes. For sw-entity-multi-select it would looks like this v-model:entityCollection, as it does not bind on value. See https://v3-migration.vuejs.org/breaking-changes/v-model.html for further details.

silviokennecke commented 4 months ago

Released: https://github.com/HEPTACOM/HeptacomShopwarePlatformAdminOpenAuth/releases/tag/7.0.0