search

HEPTACOM / HeptacomShopwarePlatformAdminOpenAuth

Shopware plugin to allow open auth logins in the administration
https://www.heptacom.de/
Apache License 2.0
30 stars 10 forks source link

task: update dependency for php8 #4

Closed htuscher closed 2 years ago

htuscher commented 2 years ago

thenetworg/oauth2-azure is not compatible with PHP8

JoshuaBehrens commented 2 years ago

I don't want to question the need of this change. I see that the package is not compatible but we use it on environments where we run php 8. How do you use it and how did you find that issue? This would be crucial to know for our testing.

htuscher commented 2 years ago

We are very strict with our composer configuration regarding PHP versions:

{
    "require": {
        "php": "^8.0"
    },
    "config": {
        "platform": {
            "php": "8.0.10"
        }
    },

So we're sure the package maintainers know what they are doing. With this configuration we can't install your OAuth Bundle as the package thenetworg/oauth2-azure in version 1.x is only flagged compatible with PHP7.

    "require": {
        "php": "^5.6|^7.0",
JoshuaBehrens commented 2 years ago

Thank you @hhoechtl for the insights. We test in the production template and as it is 6.4 based it is restricted to 7.4.3. We will add tests towards that in the future :)

JoshuaBehrens commented 2 years ago

@hhoechtl for now it looks good to us. We suggest to allow installation of both packages as well php 8.0. We will further have to provide the ZIP file in the community store as php7.4. Does this work out for you?

htuscher commented 2 years ago

Sure

JoshuaBehrens commented 2 years ago

I also added changelog entries and some CI tests for the php8.0 and php8.1 installations :)