search

HEPonHPC / apprentice

Other
9 stars 8 forks source link

Remove decode() in io.py for yoda.__version__ #12

Closed jackal1-66 closed 4 months ago

jackal1-66 commented 6 months ago

Describe the bug yoda.version does not need decode in io.py

To Reproduce Steps to reproduce the behavior:

  1. Installed YODA 1.9.8
  2. Installed Apprentice
  3. Run yoda-datadirtojson
  4. See error

Expected behavior The version comparison should work

Desktop (please complete the following information):

Additional context I tested only one version of YODA(1.9.8) however I don't see any commits on the version format in the official YODA gitlab repository. I must add that I used Python 3.10.13 in case it helps

smrenna commented 4 months ago

Making your change caused a problem on my side, so the effect must be in our versions of code.

smrenna commented 4 months ago

The command is "app-datadirtojson". I have changed the check on versioning in the master, so I am going to resolve this.