Closed pkgw closed 7 years ago
Confirmed that this patch gives us a much more tractable way to embed antenna names in HERA data sets. As such we'd like to prioritize merging this and making a new aipy release that includes the fix.
CC @bhazelton.
This is becoming important in order to get the information we need into the correlator files. @AaronParsons are you the authorized approver of PRs for this repo?
MAXVAR is the maximum number of UV variables allowed, not the maximum size of any variable in bytes.
We are still dodgy in
UVObject_rdvr
because we don't check that our buffer (value
) can actually fit the variable that is being read, which consists oflength
items. This is a bit of a hassle to check since to check for overflow we need to switch over the variable type to know how many bytes each item is.