search

HERA-Team / aipy

Astronomical Interferometry in PYthon (AIPY)
http://pypi.python.org/pypi/aipy
Other
43 stars 29 forks source link

get_description() in setup.py returns a blank string #46

Closed andrewasheridan closed 6 years ago

andrewasheridan commented 6 years ago

https://github.com/HERA-Team/aipy/blob/3a3844904dbb79308be3967715cbd12d27c7df46/setup.py#L30-L37

Calling get_description() outputs ' '

Changing lines 35 & 36 to :

elif d_start is not None and L.startswith('##') is True:
    return ' '.join(lines[d_start:cnt])

Changes the output to:

' This package collects together tools for radio astronomical interferometry. In addition to pure-python phasing, calibration, imaging, and deconvolution code, this package includes interfaces to MIRIAD (a Fortran interferometry package) and HEALPix (a package for representing spherical data sets).  Instructions, documentation, and a FAQ may be found at [the aipy GitHub page](http://github.com/HERA-Team/aipy). '
pkgw commented 6 years ago

Thanks! I've submitted PR #47 which fixes this in a way that I find to be a bit more elegant. (FWIW, instead of x is True you can usually just write x.)