HERA-Team / hera-validation

Archive of formal software pipeline validation tests
http://hera.pbworks.com/w/page/130621356/Validation
0 stars 3 forks source link

Step 3.3: Test of xRFI #41

Open steven-murray opened 5 years ago

steven-murray commented 5 years ago

This test is the first explicit test of xRFI. The idea is to use hera_sim to add RFI to a fiducial simulation including EoR and FG, and then use xRFI to flag it, and then use pspec to determine a power spectrum after flagging.

Why this test is required

21 and #22 check the performance of pspec with realistic flags (more realistic than this will generate), thus this is not a particularly good test of how pspec deals with flags. What it adds is two things: 1) how well xRFI does in terms of accuracy of removing RFI, and 2) how much the inaccuracy propagates through to the power spectrum.

Summary

A brief step-by-step description of the proposed test follows:

Simulation Details

Criteria for Success

r-pascua commented 5 years ago

@lwhitler to chat with @adampbeardsley to figure out how to fix bug with xrfi (xrfi has no check attribute) and to determine proper use of noise--does xrfi expect a realistic level of noise, or does it just need enough noise to have finite chi-squared values?

adampbeardsley commented 5 years ago

What do you mean check attribute?

xrfi uses the noise to quantify the outlier-ness of data points. Having no noise will result in divisions by zero. Have unrealistic noise will result in unrealistic flagging. But if you abstract the performance in terms of SNR, I suppose any level should be ok. Of course the detrending of the actual signal isn't going to be perfect, so there will be some mutual coupling between noise and signal level, but I think that's second order.

r-pascua commented 5 years ago

@lwhitler can you post a screenshot of the error you showed in the telecon?

lwhitler commented 5 years ago

@adampbeardsley

If run_check=True in xrfi.xrfi_run(), this happens: image

And run_check=False is a different error: image

adampbeardsley commented 5 years ago

Ah, this is an pyuvdata version issue. If you update pyuvdata (may need to do so from source, I'm not sure if it's in a release yet), you should be good to go.