search

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
11 stars 8 forks source link

VisClean.vis_clean api changes now breaking my code #640

Open nkern opened 4 years ago

nkern commented 4 years ago

@anguta @jsdillon Having pulled down new versions of hera_cal on lustre for the first time in a few months I am discovering new changes that were made to vis_clean in May that I don't think I was consulted on, specifically a "vis_clean revamp" API change that is now breaking my code (#597). I see that I was asked for a review but didn't get to it and the PR was merged anyways. In the future, let's try to be a little more careful about API changes and getting all invested parties signed off on a PR before it is merged (vis_clean is kind of a standout b/c I wrote it entirely and was probably its only user up until now).

I'll see if I can edit my analysis code to fit the new API. If I can I'll close the issue, otherwise we need to open a new PR to make vis_clean backwards compatible with the stuff that was in there.

jsdillon commented 4 years ago

Sorry about that! I don't think the API was to terribly broken, so LMK if you need me to review a PR.