HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
12 stars 8 forks source link

Autos only abs amp logcal #832

Open ele-rath opened 1 year ago

ele-rath commented 1 year ago

changed steps 1 and 2 in post_redcal_abscal_run

zacharymartinot commented 1 year ago

I think passing both autos_only_abs_amp_logcal=True and use_abs_amp_lincal=True should be considered inconsistent input, and maybe raise an error, since Abscal Step 5 essentially overwrites step 1.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.14% // Head: 97.06% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (b78192b) compared to base (3afed09). Patch coverage: 92.30% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #832 +/- ## ========================================== - Coverage 97.14% 97.06% -0.09% ========================================== Files 18 16 -2 Lines 8445 8101 -344 ========================================== - Hits 8204 7863 -341 + Misses 241 238 -3 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_cal/pull/832?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/abscal.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/832/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvYWJzY2FsLnB5) | `95.69% <92.30%> (-1.07%)` | :arrow_down: | | [hera\_cal/\_\_init\_\_.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/832/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvX19pbml0X18ucHk=) | | | | [hera\_cal/apply\_cal.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/832/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvYXBwbHlfY2FsLnB5) | | | | [hera\_cal/redcal.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/832/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvcmVkY2FsLnB5) | `99.31% <0.00%> (+<0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.