search

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
12 stars 8 forks source link

Firstcal offsets #839

Closed AaronParsons closed 1 year ago

AaronParsons commented 1 year ago

OoM speedup to firstcal

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.34% // Head: 97.32% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (5a4f8a0) compared to base (9aa9261). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 5a4f8a0 differs from pull request most recent head 609a155. Consider uploading reports for the commit 609a155 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #839 +/- ## ========================================== - Coverage 97.34% 97.32% -0.03% ========================================== Files 17 17 Lines 8250 8179 -71 ========================================== - Hits 8031 7960 -71 Misses 219 219 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_cal/pull/839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/redcal.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvcmVkY2FsLnB5) | `99.15% <100.00%> (-0.06%)` | :arrow_down: | | [hera\_cal/utils.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvdXRpbHMucHk=) | `96.24% <100.00%> (-0.01%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

AaronParsons commented 1 year ago

@jsdillon Assuming this passes, I addressed all your comments.