search

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
11 stars 8 forks source link

Make redcal_run_write_results write omnical visibilities with the same baselines for both pols #842

Closed jsdillon closed 2 years ago

jsdillon commented 2 years ago

This was breaking RTP when most of one polarization was flagged but not the other.

Now missing unique baseline visibilities are in the output file, but flagged (with zero nsamples).

jsdillon commented 2 years ago

@r-pascua verbally approved this PR subject to tests passing

codecov[bot] commented 2 years ago

Codecov Report

Base: 97.32% // Head: 97.32% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (9084030) compared to base (a5c2bf2). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 9084030 differs from pull request most recent head 805ba9d. Consider uploading reports for the commit 805ba9d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #842 +/- ## ======================================= Coverage 97.32% 97.32% ======================================= Files 17 17 Lines 8179 8184 +5 ======================================= + Hits 7960 7965 +5 Misses 219 219 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_cal/pull/842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/redcal.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/842/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvcmVkY2FsLnB5) | `99.16% <100.00%> (+<0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.