search

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
11 stars 8 forks source link

Make amplitude calibration optional in `post_redcal_abscal` #847

Closed jsdillon closed 1 year ago

jsdillon commented 1 year ago

This PR makes it possible to skip amplitude calibration entirely in post_redcal_abscal. This is useful for doing amplitude calibration with just autos completely separately from phase calibration with crosses.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.33% // Head: 97.18% // Decreases project coverage by -0.15% :warning:

Coverage data is based on head (681b6bf) compared to base (18324ae). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #847 +/- ## ========================================== - Coverage 97.33% 97.18% -0.16% ========================================== Files 17 19 +2 Lines 8223 8633 +410 ========================================== + Hits 8004 8390 +386 - Misses 219 243 +24 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_cal/pull/847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/abscal.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/847/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvYWJzY2FsLnB5) | `96.81% <100.00%> (+<0.01%)` | :arrow_up: | | [hera\_cal/apply\_cal.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/847/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvYXBwbHlfY2FsLnB5) | `94.28% <0.00%> (ø)` | | | [hera\_cal/\_\_init\_\_.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/847/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvX19pbml0X18ucHk=) | `91.30% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.