HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
12 stars 8 forks source link

Interleaving #848

Closed aewallwi closed 1 year ago

aewallwi commented 1 year ago

Add capability to fringe-rate filter and to average data over interleaved time sets.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.07% // Head: 97.07% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (5741140) compared to base (6f6318f). Patch coverage: 97.40% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #848 +/- ## ========================================== - Coverage 97.07% 97.07% -0.01% ========================================== Files 20 20 Lines 8816 8951 +135 ========================================== + Hits 8558 8689 +131 - Misses 258 262 +4 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_cal/pull/848?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/frf.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/848?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvZnJmLnB5) | `97.79% <97.35%> (-0.20%)` | :arrow_down: | | [hera\_cal/vis\_clean.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/848?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvdmlzX2NsZWFuLnB5) | `97.77% <100.00%> (+<0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

aewallwi commented 1 year ago

Coverage has actually increased despite what CodeCov is claiming at the moment.

aewallwi commented 1 year ago

Thanks for the review @jsdillon. I think this is ready for another look!

aewallwi commented 1 year ago

@jsdillon, sorry for the back-and-forth. Ended up adding an additional kwarg for interleaving but failed to push before you took a look. Can you give this one last pass?