HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
11 stars 8 forks source link

Remove deprecated numpy types #853

Closed jsdillon closed 1 year ago

jsdillon commented 1 year ago

This PR removes types like np.int and np.float and np.str that were deprecated in numpy 1.24: https://numpy.org/devdocs/release/1.24.0-notes.html

This PR relies on https://github.com/HERA-Team/hera_filters/pull/7

This PR also fixes the pyuvdata version to 2.12.2 until we can fix the phasing issue (see #851) and moves to using the newest version of aipy on github, since the version on pypi is out of date

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.18% // Head: 97.18% // No change to project coverage :thumbsup:

Coverage data is based on head (29e3503) compared to base (8c89900). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 29e3503 differs from pull request most recent head 6963d49. Consider uploading reports for the commit 6963d49 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #853 +/- ## ======================================= Coverage 97.18% 97.18% ======================================= Files 19 19 Lines 8635 8635 ======================================= Hits 8392 8392 Misses 243 243 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_cal/pull/853?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/abscal.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/853/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvYWJzY2FsLnB5) | `96.82% <100.00%> (ø)` | | | [hera\_cal/datacontainer.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/853/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvZGF0YWNvbnRhaW5lci5weQ==) | `97.93% <100.00%> (ø)` | | | [hera\_cal/io.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/853/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvaW8ucHk=) | `98.53% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.