HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
11 stars 8 forks source link

perf: don't discard imag autos Nbls times #857

Closed steven-murray closed 1 year ago

steven-murray commented 1 year ago

Un-indents the discard autocorr imag calls so they're not run for every baseline.

Interesting fact: I found that these three lines were taking >75% of the total time for doing the delay filter on H6C data.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.18% // Head: 97.18% // No change to project coverage :thumbsup:

Coverage data is based on head (041a7b7) compared to base (d2b157e). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #857 +/- ## ======================================= Coverage 97.18% 97.18% ======================================= Files 19 19 Lines 8643 8643 ======================================= Hits 8400 8400 Misses 243 243 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_cal/pull/857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/vis\_clean.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvdmlzX2NsZWFuLnB5) | `97.76% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.