search

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
12 stars 8 forks source link

Temporarily restore old array shape compatibility in HERAData for the sake of pspec #864

Closed steven-murray closed 1 year ago

steven-murray commented 1 year ago

This fixes compatibility with hera_pspec, which does not yet have future array shape support. I opened https://github.com/HERA-Team/hera_pspec/issues/373 to make this happen, so we can revert to future array shapes after that.

adeliegorce commented 1 year ago

Hi, I don't think I can review because I don't know hera_cal but just for info: I do think it is a numpy version problem because now calling np.float throws an error when before is was only a DeprecationWarning

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.08% // Head: 97.07% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (eff4762) compared to base (541d065). Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #864 +/- ## ========================================== - Coverage 97.08% 97.07% -0.02% ========================================== Files 19 19 Lines 8648 8652 +4 ========================================== + Hits 8396 8399 +3 - Misses 252 253 +1 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_cal/pull/864?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/io.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/864?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvaW8ucHk=) | `98.41% <83.33%> (-0.08%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.