HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

New abscal phase solver #876

Closed tyler-a-cox closed 1 year ago

tyler-a-cox commented 1 year ago

This PR folds in @zacharymartinot new abscal phase gradient solver. The new solver uses FFTs in position space to solve for the per-frequency phase gradient, and seems much less sensitive to large errors in phase than the existing methods.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (460fbef) 97.08% compared to head (e4b4a42) 97.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #876 +/- ## ========================================== + Coverage 97.08% 97.11% +0.02% ========================================== Files 20 20 Lines 9001 9092 +91 ========================================== + Hits 8739 8830 +91 Misses 262 262 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_cal/pull/876?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/abscal.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/876?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvYWJzY2FsLnB5) | `96.99% <100.00%> (+0.16%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.