search

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

feat: allow setting freq_scale to zero to avoid smoothing #883

Closed steven-murray closed 1 year ago

steven-murray commented 1 year ago

This just makes it possible to set time_scale and/or freq_scale to zero to avoid actually doing smoothing. While this is maybe a little counter-intuitive, it makes it easier to have pipelines with a CAL_SMOOTH step where the refant is chosen, and .smooth.calfits files are written, but without actually doing smoothing.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 :tada:

Comparison is base (43c8fd9) 97.05% compared to head (0cddda2) 97.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #883 +/- ## ========================================== + Coverage 97.05% 97.11% +0.05% ========================================== Files 20 20 Lines 9106 9114 +8 ========================================== + Hits 8838 8851 +13 + Misses 268 263 -5 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_cal/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/smooth\_cal.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvc21vb3RoX2NhbC5weQ==) | `96.68% <100.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://codecov.io/gh/HERA-Team/hera_cal/pull/883/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jsdillon commented 1 year ago

I don't think this will actually work. The proper way to do this is with the axis argument.

jsdillon commented 1 year ago

But I'm fine adding in an axis = 'none' way to not smooth along either axis but still do the refant stuff.

steven-murray commented 1 year ago

I think it does work, but the axis='none' argument sounds better.