search

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

Fix reconstitute interleaving features #886

Open aewallwi opened 1 year ago

aewallwi commented 1 year ago

Modify vis_clean.time_chunk_from_baseline_chunks code so that all interleaves will fall into the same final labeled time bin in makeflow which are set by the LSTs every stride_length. Without this fix, the time averages for different "interleaves" can fall into different makeflow file indices when we undo the cornerturn after performing time averaging.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 95.83% and project coverage change: +0.04 :tada:

Comparison is base (e712061) 97.14% compared to head (b6ecdfb) 97.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #886 +/- ## ========================================== + Coverage 97.14% 97.18% +0.04% ========================================== Files 21 21 Lines 9354 9392 +38 ========================================== + Hits 9087 9128 +41 + Misses 267 264 -3 ``` | [Impacted Files](https://codecov.io/gh/HERA-Team/hera_cal/pull/886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/vis\_clean.py](https://codecov.io/gh/HERA-Team/hera_cal/pull/886?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvdmlzX2NsZWFuLnB5) | `97.62% <95.83%> (-0.16%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://codecov.io/gh/HERA-Team/hera_cal/pull/886/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.