Closed steven-murray closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.04
:tada:
Comparison is base (
a3aebb3
) 97.15% compared to head (1c0bcab
) 97.20%.:exclamation: Current head 1c0bcab differs from pull request most recent head cc27557. Consider uploading reports for the commit cc27557 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This just adds a new
RedundantGroups
class that does a very similar thing to theRedDataContainer
except that it doesn't worry about actual data, i.e. it's just a management class for the redundant baseline groups themselves. I've added an attribute to theRedDataContainer
that points to one of these objects, which stands in as the redundant groups of the array rather than the data itself.Some points I noticed on the way:
test_redcal_run
test was failing on my own system in this PR, and I thought I'd screwed something up, but I tested it on main as well and it failed. That same test is one that randomly fails inlinsolve
sometimes, so I think there's something brittle about it that I don't understand.RedDataContainer
is weirdly mixing data keys and array keys is making some things not work. By that, I mean that the key by which it indexes a redundant group is either the first bl in the group that also exists in the data, if such a key exists, OR it's just the first in the group. This is going to mean that when you read different files and set the keys by which redundant averaged data is indexed, they can be different. I think it might make more sense to be a bit more clear about this distinction in the class.