HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

LST-binned Calibration #891

Closed tyler-a-cox closed 2 months ago

tyler-a-cox commented 1 year ago

This PR adds a new module that allows the user to calibrate days within a particular LST-bin with respect to each other. The goal of this approach is to reduce the variance in an LST-bin before binning data together by correcting deviations in per-day calibration. This PR only supports modifying the abscal degrees of freedom and does not allow per-antenna calibration to be touched.

codecov[bot] commented 1 year ago

Codecov Report

Attention: Patch coverage is 98.98649% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 97.29%. Comparing base (e56a686) to head (950fdfc).

Files Patch % Lines
hera_cal/lstcal.py 98.97% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #891 +/- ## ========================================== + Coverage 97.24% 97.29% +0.04% ========================================== Files 30 31 +1 Lines 10669 10964 +295 ========================================== + Hits 10375 10667 +292 - Misses 294 297 +3 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/891/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/891/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `97.29% <98.98%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jsdillon commented 2 months ago

closing in favor of #953