Open tyler-a-cox opened 1 year ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
b045b6e
) 97.16% compared to head (5241467
) 97.18%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR adds a new sky-based calibration function to the
abscal
module. There are currently functions for performing traditional sky-based calibration (amp_logcal
andphs_logcal
), but both are quite slow as they involve matrix inversions. This new function,sky_calibration
, implements theStEfCal
algorithm (Salvini et al 2014) which scales as nants^2. Below is a time comparison between the existing abscal functions and the new methodAnd here is a comparison of the residuals of the two methods, showing nearly identical results for the two approaches
I also tested on H6C data using redundantly-calibrated, redundantly-averaged data as the sky model and found that the redundantly-calibrated data and sky-calibrated data agree quite well. Below are the delay-transformed redundantly calibration and sky-calibrated visibilities for a single baseline type.