search

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

Modify RedDataContainer setter method #894

Closed tyler-a-cox closed 1 year ago

tyler-a-cox commented 1 year ago

Addresses https://github.com/HERA-Team/hera_cal/issues/893

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0609230) 97.20% compared to head (1851126) 97.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #894 +/- ## ======================================= Coverage 97.20% 97.20% ======================================= Files 21 21 Lines 9362 9365 +3 ======================================= + Hits 9100 9103 +3 Misses 262 262 ``` | [Impacted Files](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/894?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/datacontainer.py](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/894?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvZGF0YWNvbnRhaW5lci5weQ==) | `98.37% <100.00%> (+0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

steven-murray commented 1 year ago

I am going to have a bit more of a look, because I think this might technically break the logic, and also doesn't solve the general case. I will get to it soon

steven-murray commented 1 year ago

@tyler-a-cox actually I think the logic is sound, and this will speed up some cases (I presume your case, at least). It won't speed up the case where you start with no baselines in your object, then you go and set baselines, adding them in iteratively. I think I can make another PR to handle that case.