Closed tyler-a-cox closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
0609230
) 97.20% compared to head (1851126
) 97.20%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I am going to have a bit more of a look, because I think this might technically break the logic, and also doesn't solve the general case. I will get to it soon
@tyler-a-cox actually I think the logic is sound, and this will speed up some cases (I presume your case, at least). It won't speed up the case where you start with no baselines in your object, then you go and set baselines, adding them in iteratively. I think I can make another PR to handle that case.
Addresses https://github.com/HERA-Team/hera_cal/issues/893