search

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

Detect and account for 180 degree phase flips in smooth_cal #897

Closed jsdillon closed 1 year ago

jsdillon commented 1 year ago

This PR adds automatic detection of 180 degree phase flips (on by default) before smoothing, which are incorporated in the rephasor applied before smoothing and then taken back out after smoothing.

It also adds functionality to flag integrations before and after phase flips, under the assumption that the phase flip may have happened mid-integration.

Here's a demonstration:

image

image

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1e35a7b) 97.20% compared to head (8d55059) 97.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #897 +/- ## ======================================= Coverage 97.20% 97.21% ======================================= Files 21 21 Lines 9414 9442 +28 ======================================= + Hits 9151 9179 +28 Misses 263 263 ``` | [Impacted Files](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/smooth\_cal.py](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/897?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvc21vb3RoX2NhbC5weQ==) | `96.93% <100.00%> (+0.18%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jsdillon commented 1 year ago

Here's a demonstration with a full day

image