search

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

Give LST-binned files sensible JDs #902

Closed jsdillon closed 10 months ago

jsdillon commented 1 year ago

Right now, the new lstbin_simple.py assigns times/JDs to files that can cause visibilities to load out of order in pyuvdata. Here's an example:

image

This leads to annoying effects when loading large waterfalls. For example:

image

Since the JDs are arbitrary, we should pick a starting LST and a JD that corresponds to, and then all LSTs after that (even after the 2pi phase wrap) would correspond to larger JDs.

This came up in H1C, which is why LST2JD has some utility parameters to make this easier: https://github.com/HERA-Team/hera_cal/blob/e68775af51dead44879d2ed3bc8860185bda3c51/hera_cal/utils.py#L550

steven-murray commented 10 months ago

I believe this was fixed in #469, @jsdillon are you happy with the current solution?

jsdillon commented 10 months ago

Yeah, looks good.