HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

fix some things that will error in pyuvdata 3.0 #909

Closed bhazelton closed 1 year ago

bhazelton commented 1 year ago

This future proofs for pyuvdata v3.0 which is coming soonish.

jsdillon commented 1 year ago

This PR is failing a bunch of tests... do we expect it to pass before pyuvdata 3.0?

bhazelton commented 1 year ago

Sigh. I though it would but I forgot that I fixed the spelling of the flags_array to flag_array in write_uvh5_part because it didn't match the spelling throughout the rest of the code base. I'll fix it to work now and in the future, it'll just be a little clunky.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.01% :warning:

Comparison is base (5693047) 97.19% compared to head (822d0cb) 97.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #909 +/- ## ========================================== - Coverage 97.19% 97.18% -0.01% ========================================== Files 23 23 Lines 10429 10433 +4 ========================================== + Hits 10136 10139 +3 - Misses 293 294 +1 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/909/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/909/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `97.18% <88.88%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/utils.py](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvdXRpbHMucHk=) | `95.63% <83.33%> (ø)` | | | [hera\_cal/io.py](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvaW8ucHk=) | `98.08% <90.00%> (-0.08%)` | :arrow_down: | | [hera\_cal/smooth\_cal.py](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/909?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvc21vb3RoX2NhbC5weQ==) | `97.00% <100.00%> (+<0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bhazelton commented 1 year ago

Ok, I made the issue. What do you want to do about the code coverage? I can add a pragma: no cover to the code branch for pyuvdata > 3.0 if you like. The other line was apparently already not covered, I just made the syntax pep8 compliant.

jsdillon commented 1 year ago

I can live with the tiny decrease in coverage.