HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

improve handling for future pyuvdata #915

Closed bhazelton closed 10 months ago

bhazelton commented 10 months ago

This is a small tweak to ensure that hera_cal tests pass on the branch we're using to prepare for version 3.0. Since we haven't reached v3.0 yet the desired code branch isn't being used. This fixes the code to look at the actual function signature rather than the pyuvdata version so the correct branch is used.

The coverage issue is because CI is only running against current pyuvdata versions.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (102e14f) 97.18% compared to head (820dd60) 97.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #915 +/- ## ======================================= Coverage 97.18% 97.18% ======================================= Files 23 23 Lines 10444 10446 +2 ======================================= + Hits 10150 10152 +2 Misses 294 294 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/915/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/915/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `97.18% <83.33%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/915?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/io.py](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/915?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvaW8ucHk=) | `98.09% <83.33%> (+<0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.