HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

Allow user to impose a u-cut when generating PSWF filters for nucal #917

Closed tyler-a-cox closed 9 months ago

tyler-a-cox commented 9 months ago

This PR allows users to set maximum and minimum u-bounds when generating PSWF basis functions for a nucal fit. This can be particularly useful when the user is attempting to fit a spectrally redundant group of baselines, where one of the baselines is significantly longer than the others. This can drastically increase the number of parameters without improving the fit of the other baselines. By restricting the u-axis, we can reduce the number of parameters involved in the fit while still allowing longer baselines to contribute to constraining spectral redundancy for the group.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0f1b175) 97.17% compared to head (38e3748) 97.17%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #917 +/- ## ======================================= Coverage 97.17% 97.17% ======================================= Files 23 23 Lines 10486 10488 +2 ======================================= + Hits 10190 10192 +2 Misses 296 296 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/917/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/917/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `97.17% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [hera\_cal/nucal.py](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#diff-aGVyYV9jYWwvbnVjYWwucHk=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.