search

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

fix: use uint dtype for ant numbers to comply with pyuvdata #925

Closed steven-murray closed 7 months ago

steven-murray commented 8 months ago

This applies the patch suggested by @mkolopanis here.

Basically it allow the antenna numbers to be np.uint type instead of basic int.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c2f2c41) 97.18% compared to head (4d31ff2) 97.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #925 +/- ## ======================================= Coverage 97.18% 97.18% ======================================= Files 23 23 Lines 10504 10504 ======================================= Hits 10208 10208 Misses 296 296 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/925/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/925/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `97.18% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

steven-murray commented 8 months ago

Leaving this as draft in case we wanna do the "right" thing later.

jsdillon commented 8 months ago

I'm not convinced that this is the "right" thing... I much prefer the other solution.