search

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

fix: enforce that ant numbers are uint64 #926

Closed steven-murray closed 8 months ago

steven-murray commented 8 months ago

Fixes writing out uvdta objects according to this PR: https://github.com/RadioAstronomySoftwareGroup/pyuvdata/pull/1357#issuecomment-1830436169.

steven-murray commented 8 months ago

Currently it will raise a Deprecation warning. We wanna escalate that to error?

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c2f2c41) 97.18% compared to head (f1ea817) 97.17%.

Files Patch % Lines
hera_cal/io.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #926 +/- ## ========================================== - Coverage 97.18% 97.17% -0.01% ========================================== Files 23 23 Lines 10504 10507 +3 ========================================== + Hits 10208 10210 +2 - Misses 296 297 +1 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/926/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/926/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `97.17% <80.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.