HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

Apply flag to N-sample before delay filtering #929

Closed Kai-FengChen closed 6 months ago

Kai-FengChen commented 6 months ago

Add an option in load_delay_filter_and_write so that we can add the flags to the N-sample array before delay filtering (i.e., setting nsample[flag == True] = 0). Write a new test to support this new option. Also modify the run script.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (45ed23c) 97.17% compared to head (4054461) 97.17%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #929 +/- ## ======================================= Coverage 97.17% 97.17% ======================================= Files 23 23 Lines 10507 10520 +13 ======================================= + Hits 10210 10223 +13 Misses 297 297 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/929/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/929/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `97.17% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.