HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

Lstbin subpackage #935

Closed steven-murray closed 6 months ago

steven-murray commented 6 months ago

This moves the new lst-binning functionality to a sub-package, called lst_stack. Suggestions on the best name are welcome. I've kept the old lstbin.py module in place but added a deprecation warning, and removed tests for it. It should be removed after H4C is done and dusted.

927 should be merged first.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (de4d678) 97.12% compared to head (3b1eaa3) 97.17%.

Files Patch % Lines
hera_cal/lst_stack/config.py 94.20% 8 Missing :warning:
hera_cal/lst_stack/wrappers.py 97.87% 4 Missing :warning:
hera_cal/lst_stack/io.py 97.45% 3 Missing :warning:
hera_cal/lst_stack/binning.py 99.47% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #935 +/- ## ========================================== + Coverage 97.12% 97.17% +0.04% ========================================== Files 23 28 +5 Lines 10709 10218 -491 ========================================== - Hits 10401 9929 -472 + Misses 308 289 -19 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/935/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/935/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `97.17% <97.97%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.