codecov[bot]
commented
6 months ago Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (
be00ed9) 97.15% compared to head (112285a) 97.12%.
| Files | Patch % | Lines |
|---|---|---|
| hera_cal/io.py | 93.75% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #937 +/- ## ========================================== - Coverage 97.15% 97.12% -0.04% ========================================== Files 23 23 Lines 10692 10709 +17 ========================================== + Hits 10388 10401 +13 - Misses 304 308 +4 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/937/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/937/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `97.12% <98.41%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR adds a test that fails if warnings are emitted. We needn't enforce this check to pass on PRs, but it will warn us more clearly when there are deprecations etc.
I've fixed as many warnings as I could. This was quite a pain. I definitely recommend that someone with a bit more hera-cal knowledge go through and check that the warnings I'm silencing are appropriate. Sometimes I might be silencing something that shouldn't be.