Closed steven-murray closed 5 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
54dc2ed
) 97.17% compared to head (bdc4b0e
) 97.17%.:exclamation: Current head bdc4b0e differs from pull request most recent head eb3ba7e. Consider uploading reports for the commit eb3ba7e to get more accurate results
Files | Patch % | Lines |
---|---|---|
hera_cal/lst_stack/binning.py | 80.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This fixes a subtle bug in defining redundant groups.
The bug was manifesting when using the
keyed_on_bls()
method. This method is meant to take a particular set of redundant baselines, which have a particular unique key, and re-key so that the key must be one of a given set of baselines. However, when the given set of baselines contains the reverse of the given key, this was failing.Along with fixing this problem, this adds the
.get_bls_in_set()
method, which is a more intuitive way of doing the same operation (but is not cached for re-use as the re-keying is).