errors with scipy 1.13 related to importing window functions improperly

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.

MIT License

13 stars 8 forks source link

errors with scipy 1.13 related to importing window functions improperly #944

Open bhazelton opened 4 months ago

bhazelton commented 4 months ago

I'm seeing errors in hera_cal runs on pyuvdata related to improper scipy imports with scipy v1.13

The release notes for Scipy 1.11 say:

Importing window functions directly from scipy.window has been soft deprecated since SciPy 1.1.0. They now raise a DeprecationWarning and will be removed in SciPy 1.13.0. Users should instead import them from scipy.signal.window or use the convenience function scipy.signal.get_window.

jsdillon commented 4 months ago

I believe hera_cal only uses scipy windows via aipy or hera_filters... but I could be wrong. Can you share the errors so we can track them down?

tyler-a-cox commented 4 months ago

Looking at the error in the pyuvdata tests, it looks like this is actually an issue with hera_sim which is being called in the hera_cal tests. Steven opened a PR in hera_sim that should take care of this https://github.com/HERA-Team/hera_sim/pull/305