HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

Fix creation of UVData object in LSTStack to use proper antenna positions #950

Closed jsdillon closed 2 months ago

jsdillon commented 2 months ago

This follows from a bug @tyler-a-cox found in the lststack notebook where baseline vectors were not actually ENU coordinates, leading to underestimates of baseline vector lengths when only using E and N (but ignoring U). I think the transformation involving telescope location was being performed twice.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.18%. Comparing base (81a3ae7) to head (d03fd60).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #950 +/- ## ======================================= Coverage 97.18% 97.18% ======================================= Files 30 30 Lines 10728 10728 ======================================= Hits 10426 10426 Misses 302 302 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/950/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/950/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `97.18% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.