search

HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

Add LST-binned absolute calibration to `lst_stack` #953

Closed tyler-a-cox closed 1 month ago

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 98.07692% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.27%. Comparing base (f32a515) to head (965f362).

Files Patch % Lines
hera_cal/lst_stack/calibration.py 98.07% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #953 +/- ## ========================================== + Coverage 97.26% 97.27% +0.01% ========================================== Files 30 31 +1 Lines 10795 10951 +156 ========================================== + Hits 10500 10653 +153 - Misses 295 298 +3 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/953/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/953/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `97.27% <98.07%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tyler-a-cox commented 1 month ago

I made a few changes here, including refactoring the main calibration function into smaller modules to improve readability, fixing the polarization issues so that the J-strings are no longer hard-coded, and so the function can handle cross-polarized visibilities, added rephasing of antenna gains prior to smoothing, and smoothing antenna gains rather than antenna gain products.