HERA-Team / hera_cal

Library for HERA data reduction, including redundant calibration, absolute calibration, and LST-binning.
MIT License
13 stars 8 forks source link

Basic ruff #956

Closed steven-murray closed 1 month ago

steven-murray commented 1 month ago

This PR swaps out out flake8 checks for the same checks with ruff (to the extent possible). This is faster, and also allows them to be auto-fixed at pre-commit time. I am not currently running ruff format, which would result in black-like formatting (we could decide to add that at a later time if we want), only doing the flake8 checks/fixes. I ran the checks on the entire code-base and made all necessary fixes.

I also deleted the calibrations/ sub-folder as it wasn't being imported or used anywhere in the code. It's possible that it's being used from outside the code in some pipeline, in which case I'll put it back in.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.26%. Comparing base (9e14dde) to head (2fc1633).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #956 +/- ## ======================================= Coverage 97.26% 97.26% ======================================= Files 30 30 Lines 10795 10795 ======================================= Hits 10500 10500 Misses 295 295 ``` | [Flag](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/956/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/HERA-Team/hera_cal/pull/956/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team) | `97.26% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=HERA-Team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.